Fix arguments naming and escape operator name in usageHtml #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Will you add tests? I'm OK with taking as is. |
|
@dsyme, yes, we would like to add some tests for it in the near future. |
BoundedChenn31
force-pushed
the
dedsec256-fix-for-operators
branch
from
ced0f05 to
923ade5
Compare
BoundedChenn31
approved these changes
Aug 30, 2022
DedSec256
changed the title
|
@dsyme, we think it's ready |
dsyme
approved these changes
Aug 31, 2022
|
You probably want to exclude these from code formatting, or else format them |
|
@dsyme, it could be merged I think (: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some operator names are displayed incorrectly due to missing escaping; also, the argument names are duplicated.
This PR fixes that.
Before:
https://github.com/dotnet/fsharp/blob/0063f20f6cd49d016d5d234b9c1b7df00c2e9a4d/src/FSharp.Core/Nullable.fsi#L173
After:
cc @BoundedChenn31