Pass more commonmark emphasis parsing tests #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the code more closely follow the commonmark spec description.
dsyme
reviewed
Aug 23, 2022
|
|
||
| /// Succeeds when there's a match to a string of * or _ that could | ||
| /// open emphasis. | ||
| let inline (|LeftDelimiterRun|_|) input = |
There was a problem hiding this comment.
I'll remove the inline - these are too big to inline and there will be no useful performance gain from using it
dsyme
approved these changes
Aug 23, 2022
|
Great tests, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves parsing of markdown emphasis with * and _.
It adds 13 additional emphasis parsing tests from the commonmark spec. 8 of them currently fail on the main branch (first push will show that).
The new code in MarkdownParser.fs passes all old and new tests.