Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DiffSharp css #688

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Updated DiffSharp css #688

merged 2 commits into from
Jul 22, 2021

Conversation

gbaydin
Copy link
Contributor

@gbaydin gbaydin commented Jul 22, 2021

@dsyme this is the latest DiffSharp css as we mentioned in #687. I'm not sure how I could do the line by line copying. This PR is based on the latest master. I'm hoping it can give an indication of what needs to be merged.

@dsyme
Copy link
Contributor

dsyme commented Jul 22, 2021

Cool looking at the diff there are a few lines we can integrate here, I'll edit it down to be just those

@dsyme
Copy link
Contributor

dsyme commented Jul 22, 2021

@gbaydin I direct committed to your fix3 patch branch trimming out some of the diff

@dsyme
Copy link
Contributor

dsyme commented Jul 22, 2021

@nhirschey I'll merge, release 11.4 and you can check

@dsyme dsyme merged commit baea856 into fsprojects:master Jul 22, 2021
@dsyme
Copy link
Contributor

dsyme commented Jul 22, 2021

@nhirschey 11.3.0 doesn't have these changes, 11.4.0 has them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants