Prevent CLI parameters from being discarded #634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #633
This took a little while to hunt down. But, basically, the logic is:
dict
andreadOnlyDict
to de-duplicate valuesThe limitation of the above approach is that it is order dependent. This isn't bad, per se. But it means step one above needs to be handled carefully. So, this patch just changes the order in which things are accumulated (putting the
userParameters
at the end of the list).