Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CLI parameters from being discarded #634

Conversation

pblasucci
Copy link
Contributor

Fixes #633

This took a little while to hunt down. But, basically, the logic is:

  1. Accumulate parameters from multiple sources
  2. Rely on FSharp.Core's dict and readOnlyDict to de-duplicate values

The limitation of the above approach is that it is order dependent. This isn't bad, per se. But it means step one above needs to be handled carefully. So, this patch just changes the order in which things are accumulated (putting the userParameters at the end of the list).

@kMutagene
Copy link
Contributor

Tested and it works as you say, great catch, thanks!

@kMutagene kMutagene merged commit 453c0b8 into fsprojects:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: CLI "--parameters" are ignored
2 participants