Fix c# extension methods. #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annot get the attributes of the current member.
|
@tpetricek OK I think the owner of the repro needs to add the webhook (http://help.appveyor.com/discussions/questions/203-auto-run-tests-on-pull-requests#comment_33212404). You should be able to login into AppVeyor with your github account and then select "matthid" then you should see the project relevant settings (the webhook url). I hope I got your E-Mail address right in AppVeyor. Alternatively you can login into AppVeyor with your Github account, select your own account and then click the "add project" button on FSharp.Formatting. I think in this scenario AppVeyor will automatically add the hook to GitHub. |
…d this? Change Url to be able to push without password.
… a single member and write an error, workaround for #271 (and future FCS bugs).
|
All changes look good to me - feel free to merge this & release a new non-alpha! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #201 by updating
Yaaf.FSharp.Scriptingand makes[omit]work, even whenmarkDownCommentsis set to false.I also enabled AppVeyor and added a
appveyor.ymlfile, will test it as part of this PR.