Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The new default css based on diffsharp removed bottom margins from code output. #686

Closed
nhirschey opened this issue Jul 21, 2021 · 0 comments
Closed

The new default css based on diffsharp removed bottom margins from code output. #686

nhirschey opened this issue Jul 21, 2021 · 0 comments

Comments

@nhirschey
Copy link
Collaborator

See below screenshot from FSharp.Data. The orange is the margin. There is a bottom margin for code, but the second code block (which is showing the csv file) is missing the orange bottom margin.

image

A simple fix is to change this line that was commented out in this pull request to margin-bottom: 1em;. That will give the same margin for both code and code output.

With the change, see the bottom computed margin for code:
code

And for output:
output
nhirschey added a commit to nhirschey/FSharp.Formatting that referenced this issue Jul 21, 2021
@nhirschey
add bottom margin to included code output
f6e1473 
Addresses issue raised here fsprojects#686
@nhirschey nhirschey mentioned this issue Jul 21, 2021
Merged
dsyme pushed a commit that referenced this issue Jul 22, 2021
@nhirschey
add bottom margin to included code output (#687)
d454936 
Addresses issue raised here #686
@dsyme dsyme closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhirschey @dsyme