Updated per review comments

fsprojects · Jun 19, 2024 · c3cef1b · c3cef1b
1 parent 82f7cbe
commit c3cef1b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/src/Common/StringParsing.fs b/src/Common/StringParsing.fs
@@ -109,7 +109,7 @@ module String =
         let spaces =
             lines
             |> Seq.choose (fun line ->
-                if not <| String.IsNullOrWhiteSpace line then
+                if String.IsNullOrWhiteSpace line |> not then
                     line |> Seq.takeWhile Char.IsWhiteSpace |> Seq.length |> Some
                 else
                     None)

diff --git a/src/FSharp.Formatting.ApiDocs/GenerateModel.fs b/src/FSharp.Formatting.ApiDocs/GenerateModel.fs
@@ -2265,10 +2265,8 @@ module internal SymbolReader =
             replacedParagraphs
             |> Seq.collect collectParagraphIndirectLinks
             |> Seq.choose (fun line ->
-                if linkNotDefined doc line then
-                    getTypeLink ctx line |> Some
-                else
-                    None)
+                let linkIsDefined = linkNotDefined doc line |> not
+                if linkIsDefined then None else getTypeLink ctx line |> Some)
             |> Seq.iter (addLinkToType doc)
 
         doc.With(paragraphs = replacedParagraphs)

diff --git a/src/FSharp.Formatting.Common/Templating.fs b/src/FSharp.Formatting.Common/Templating.fs
@@ -49,9 +49,9 @@ type FrontMatterFile =
                 let isBlankLine = String.IsNullOrWhiteSpace line
                 isBlankLine || line.Contains(":"))
             |> Seq.choose (fun line ->
-                let parts = line.Split(":") |> Array.toList
+                if String.IsNullOrWhiteSpace line |> not then
+                    let parts = line.Split(":") |> Array.toList
 
-                if not <| String.IsNullOrWhiteSpace line then
                     match parts with
                     | first :: second :: _ -> Some(first.ToLowerInvariant(), second)
                     | _ -> None