Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fsdocs #1496

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Update fsdocs #1496

merged 2 commits into from
Nov 13, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Nov 11, 2023

Hi there, I've been working on a new theme for FSharp.Formatting.
I would like to start rolling out the latest alpha and gather some real-world feedback.

Other examples:

Thanks for considering this PR!

@Thorium
Copy link
Member

Thorium commented Nov 13, 2023

This PR seems to pass CI and current master doesn't.

@nojaf
Copy link
Contributor Author

nojaf commented Nov 13, 2023

Yes, I believe master doesn't have the fix of dc356ce

Copy link
Collaborator

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, main passed the last time I touched it for a release. But regardless, if it's green here then it should be green for docs too.

@cartermp cartermp merged commit 6c998cc into fsprojects:main Nov 13, 2023
2 checks passed
@nojaf
Copy link
Contributor Author

nojaf commented Nov 14, 2023

Not sure what went wrong in https://github.com/fsprojects/FSharp.Data/actions/runs/6855774344/job/18641541374

This works on my local Windows machine.

@Thorium
Copy link
Member

Thorium commented Nov 14, 2023

I merged the main to my 4 PRs and 2 passed, 2 failed. They all pass in my machine. So this is a random failure.

@Thorium
Copy link
Member

Thorium commented Nov 14, 2023

It seems to me that it's a network error in WorldBank provider. Not sure why unit tests are doing network requests.

@cartermp
Copy link
Collaborator

@nojaf
Copy link
Contributor Author

nojaf commented Nov 16, 2023

Yes, thank you!

@Thorium
Copy link
Member

Thorium commented Mar 13, 2024

The current 6.4.0 release build didn't create a NuGet package, because build failed after spending about 6 hours in the document generation phase:

GenerateDocs 05:57:06.9700490 (Failed to generate docs)

Details: https://github.com/fsprojects/FSharp.Data/actions/runs/8258675234/job/22591313017#step:6:1764

@nojaf
Copy link
Contributor Author

nojaf commented Mar 13, 2024

Mildly interesting, you could try and update to v20 stable and see if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants