Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix260chars win #955

Merged
merged 6 commits into from
Oct 2, 2015
Merged

Fix260chars win #955

merged 6 commits into from
Oct 2, 2015

Conversation

davidpodhola
Copy link
Contributor

When building a complex project on Windows (e.g. including deep structures like "C:\Users\DAVID1.POD\Source\WORKSP1\FSHARP1\src\FSHARP2\NODE_M1\GR2FD01\NODE_M1\maxmin\NODE_M1\PRETTY1\NODE_M1\meow\NODE_M1\INDENT1\NODE_M1\REPEAT1\NODE_M1\IS-FIN1\node_modules\number-is-nan" ) the PathTooLongException is thrown.
I think there is nothing to do, but the build should go on.

(Sorry for the commit-revert-commit, I forgot to create the branch first)

@cdrnet
Copy link
Member

cdrnet commented Sep 18, 2015

Skipping files without any kind of hint or warning sounds a bit dangerous to me.

@davidpodhola
Copy link
Contributor Author

@cdrnet you are right. What about the same warning dir produces?
dir 160 chars problem

@davidpodhola
Copy link
Contributor Author

@cdrnet looks better?

@cdrnet
Copy link
Member

cdrnet commented Sep 30, 2015

Yes, much better - thanks!

forki added a commit that referenced this pull request Oct 2, 2015
@forki forki merged commit 98b3652 into fsprojects:master Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants