-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ReportGeneratorHelper to add Badges report type #943
Merged
forki
merged 17 commits into
fsprojects:master
from
rmckirby:addreportgeneratorbadgetype
Sep 11, 2015
Merged
Extend ReportGeneratorHelper to add Badges report type #943
forki
merged 17 commits into
fsprojects:master
from
rmckirby:addreportgeneratorbadgetype
Sep 11, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will assist in spec testing the Helper.
Not sure about this, now we are building strings that could potentially not be used.
… to ensure validity.
Additional tests in place.
…d in the report generator docs.
very cool. |
forki
added a commit
that referenced
this pull request
Sep 11, 2015
Extend ReportGeneratorHelper to add Badges report type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the following feature: #941
I've no familiarity with
F#
so there's probably some things that don't adhere to best practice/could be cleaner...I've also added a covering spec test as well as this was previously non-existent.