Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to optionally pass in SiteId to configure IIS Site. #905

Merged
merged 1 commit into from
Aug 13, 2015

Conversation

dmorgan3405
Copy link
Contributor

Added ability to optionally pass in SiteId to configure IIS Site. For Issue #844 .

Continued to clean up method signatures, and took a first pass at allowing defaulting faulting of SiteConfig properties. This would allow a user to implement a class, like the following, and supply defaults for the application or follow standards easier.

type UserSiteConfig(siteName:string, ?physicalPath:string)  = class
  let defaultPath = Path.Combine("c:\\inetpub\\wwwroot", siteName)
  let defaultPort = 80
  let defaultProtocol = "http"

  interface ISiteConfig with 
    member this.name = siteName
    member this.appPool = siteName
    member this.protocol = defaultProtocol 
    member this.binding = sprintf ":%d:%s" defaultPort siteName
    member this.physicalPath = defaultArg physicalPath defaultPath
    member this.id = None
end

Willing to continue to collaborate on pushing this module forward. Would love to get some unit tests wrapped around the current functionality to help test drive out future functionality.

  -  Now able to default site config properites (ISiteConfig Interface allows consumer to implement own SiteConfig class)
forki added a commit that referenced this pull request Aug 13, 2015
Added ability to optionally pass in SiteId to configure IIS Site.
@forki forki merged commit ac24498 into fsprojects:master Aug 13, 2015
@forki
Copy link
Member

forki commented Aug 13, 2015

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants