Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Squirrel helpers to generate Squirrel installers #899

Merged
merged 3 commits into from
Aug 10, 2015
Merged

Added Squirrel helpers to generate Squirrel installers #899

merged 3 commits into from
Aug 10, 2015

Conversation

andersosthus
Copy link
Contributor

Added SquirrelHelpers.fs to generate Squirrel for Windows installers (https://github.com/Squirrel/Squirrel.Windows).

The code is a cleanup of a helper I made for internal use to create Squirrel installers.

I haven't done much F# before, so if you have suggestions to improvements, that would be greatly appreciated.

@@ -0,0 +1,127 @@
[<AutoOpen>]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove auto open

@forki
Copy link
Member

forki commented Aug 5, 2015

This looks very cool. Need to take a deeper look.

BootstrapperExe = None
LoadingGif = None
ToolPath = findToolInSubPath toolname (currentDirectory @@ "tools" @@ "Squirrel")
TimeOut = TimeSpan.FromMinutes 5.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be 10min, this can take awhile

@anaisbetts
Copy link

LGTM!

@andersosthus
Copy link
Contributor Author

Yeah, I've noticed that it can take some time, so a good idea to have the default higher.

@forki
Copy link
Member

forki commented Aug 5, 2015

I'm on vacation for a couple of days, but I will merge/release when I'm back on Monday.

@forki
Copy link
Member

forki commented Aug 10, 2015

forece-squirrel-meme

forki added a commit that referenced this pull request Aug 10, 2015
Added Squirrel helpers to generate Squirrel installers
@forki forki merged commit 0ea027f into fsprojects:master Aug 10, 2015
@andersosthus andersosthus deleted the squirrel branch August 10, 2015 16:59
@sergey-tihon
Copy link
Member

OMG OMG OMG
I definitely should update our build scripts
@andersosthus Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants