Align NUnitDomainModel with NUnit documentation #897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes two things:
NUnitDomainModel
is changed fromSingleDomainModel
toDefaultDomainModel
. In additionDefaultDomainModel
is changed fromNone
to""
, causing the parameter-domain
to be excluded in the call to NUnit. This in effect reverts Nunit Domain Fix per #855 #883, as it caused regressions in exsiting build scripts (Failing NUnit tests in v4.0.2 #896) that depends on NUnit selecting the App Domain Model itself, as specified in the documentation (http://www.nunit.org/index.php?p=consoleCommandLine&r=2.5).NUnitDomainModel
,NoDomainModel
, which adds-domain:None
to the command line. This gives the same effect as the change done in Nunit Domain Fix per #855 #883, but it's now an opt-in, and not a default value.In effect:
NoDomainModel
SingleDomainModel
MultipleDomainModel
Domain = NoDomainModel
to get the intended behavior (-domain:None
)Also included tests to verify argument generation for
NUnitDomainModel
.