Get package version from nuspec file #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was using `GetPackageVersion` in FsLab. When we use Paket to get FsLab dependencies, it downloads the package `Google.DataTable.Net.Wrapper` and puts it in a file called `Google.DataTable.Net.Wrapper.3.1.2.nupkg`. However, the `nuspec` file says that the version is actually `3.1.2.0` and if you add the reference using NuGet, it places it in a directory with `3.1.2.0` in the name (and also includes the additional `.0` in the `nupkg` file name). I'm not sure if this is a bug in Paket (uses wrong file name) or if it is just NuGet giving us inconsistent information. I suspect the latter, so I'm sending a PR. But perhaps this is better handled in Paket.. not sure!
|
Nuget changed the version normalize function along the way and is inconsistent. |
forki
added a commit
that referenced
this pull request
Jun 15, 2015
Get package version from nuspec file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
GetPackageVersionin FsLab. When we use Paket to get FsLab dependencies, it downloads the packageGoogle.DataTable.Net.Wrapperand puts it in a file calledGoogle.DataTable.Net.Wrapper.3.1.2.nupkg. However, thenuspecfile says that the version is actually3.1.2.0and if you add the reference using NuGet, it places it in a directory with3.1.2.0in the name (and also includes the additional.0in thenupkgfile name).I'm not sure if this is a bug in Paket (uses wrong file name) or if it is just NuGet giving us inconsistent information. I suspect the latter, so I'm sending a PR. But perhaps this is better handled in Paket.. not sure!
(Based on code I added to the FsLab build script: fslaborg/FsLab@2475145)