-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new function to WiX helper for retrieving file id from wixDir output #804
Added new function to WiX helper for retrieving file id from wixDir output #804
Conversation
/// - `fileRegex` - Regex which matches the file name | ||
/// | ||
/// ## Sample | ||
/// let directoryString = wixDir (fun file -> true) true (DirectoryInfo directoryWithFilesForSetup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the sample code needs to be indented like https://github.com/fsharp/FAKE/blob/master/src/app/FakeLib/ZipHelper.fs#L165
very cool. only a small suggestion for the sample |
I fixed the line indentation in the sample and added a test case, not sure if it is at the right location, because I can't open FAKE correctly as it seems... |
You can't open? |
When trying to run the "getFileIdFromWiXString" function in the test, I get a "getFileIdFromWiXString is undefined" error. |
Ok, fixed the build, my tests went into the Test.Fake.Deploy.Web project, I had to add Fake as a reference, forgot that. |
f317ca6
to
b180128
Compare
…ures and custom actions
I wanted to get rid of the need to manually create a WiX XML. |
Added new function to WiX helper for retrieving file id from wixDir output
cool thanks. |
This is the first implementation of my function for retrieving a file id from a wixDir string.
It takes the wixDir string and a regex to match the executable name, which you are trying to get the id from.
It returns the first match for the given regex out of the wixDir string.
I'll add a test case soon.