Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looks in current nuspec for namespace #736

Merged
merged 1 commit into from
Apr 7, 2015
Merged

Conversation

ashic
Copy link
Contributor

@ashic ashic commented Apr 3, 2015

When Fake.Deploy is running a deployment, it looks up package details from the nuspec file. Currently, only a couple of namespaces are used, and depending on the version of nuget used, other namespaces may be in the nuspec file. For example, if the nuspec file used to generate a package doesn't have a namespace specified, any of the following may get used:

"http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd"
"http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd"
"http://schemas.microsoft.com/packaging/2011/10/nuspec.xsd"
...

This pull request will try the (currently hardcoded) values, but will also use the document's namespace. This provides more robust handling of versions.

@forki
Copy link
Member

forki commented Apr 7, 2015

cool. maybe we should "paket github link" the nuspec file from Paket.

forki added a commit that referenced this pull request Apr 7, 2015
looks in current nuspec for namespace
@forki forki merged commit 214ad94 into fsprojects:master Apr 7, 2015
@ashic ashic deleted the fb/nuspec_ns branch April 7, 2015 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants