looks in current nuspec for namespace #736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Fake.Deploy is running a deployment, it looks up package details from the nuspec file. Currently, only a couple of namespaces are used, and depending on the version of nuget used, other namespaces may be in the nuspec file. For example, if the nuspec file used to generate a package doesn't have a namespace specified, any of the following may get used:
"http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd"
"http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd"
"http://schemas.microsoft.com/packaging/2011/10/nuspec.xsd"
...
This pull request will try the (currently hardcoded) values, but will also use the document's namespace. This provides more robust handling of versions.