fsc compilation fix #601
Merged
fsc compilation fix #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // But if it's not, then figure out what it should be. | ||
| else | ||
| let outExt = | ||
| if Seq.exists (fun e -> e = "-a" || e = "--target:library") opts then ".dll" | ||
| else ".exe" | ||
| "-o" :: FileHelper.changeExt outExt (List.head srcFiles) :: opts @ srcFiles | ||
| "fsc.exe" :: "-o" :: FileHelper.changeExt outExt (List.head srcFiles) :: opts @ srcFiles |
There was a problem hiding this comment.
Can we put it without duplication on the line where the Compile get called?
|
I just moved the cons to the top. |
| @@ -50,6 +50,8 @@ let fscList (srcFiles : string list) (opts : string list) : int = | |||
| let scs = SimpleSourceCodeServices() | |||
|
|
|||
| let optsArr = | |||
| // Always prepend "fsc.exe" since fsc compiler skips the first argument | |||
| "fsc.exe" :: | |||
There was a problem hiding this comment.
Sorry to bother, I forgot to mention the other reason why it should be moved down.
optsArr will be traced out, we don't need fsc.exe in that trace message.
|
Okay that makes sense to me. |
|
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Fsc always skips the first argument, it is important to use a dummy argument when calling a Compile function. Otherwise, following compiler options can be ignored. For example, the current version of FAKE always ignores Output parameter, because "-o" is the first argument that appears in optsArr (thus, it is ignored along with the second argument that specifies the output file name). For your reference, Fsc compiler test code also includes "fsc.exe" as the first argument when calling the Compile function.