-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new SignToolHelper #535
Conversation
Do we want to mark the other one Obsolete? |
The new signer is capable of the same tasks as the old one and some new
|
How about making the new one backwards compatible?
|
Hmmm, I'd have to port over the original method's signature. I could do
|
Nice. That would make things so much more friendly
|
Added the old method provided by the old SignHelper and marked it as obsolete. Renamed the properties "File" and "Password" of the SignCert type to "CertFile" and "PasswordFile" to make it more clear what they mean. Also added documentation to those properties.
I included the old SignHelper method in the new SignToolHelper module and marked it as obsolete. The old SignHelper type is still there and unchanged. |
thanks |
Created a new SignToolHelper that is more capable than the old SignHelper. I did not change that one because it might still be in use.
Relates to issue #533