Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new SignToolHelper #535

Merged
merged 2 commits into from
Sep 19, 2014
Merged

Added new SignToolHelper #535

merged 2 commits into from
Sep 19, 2014

Conversation

Bomret
Copy link

@Bomret Bomret commented Sep 3, 2014

Created a new SignToolHelper that is more capable than the old SignHelper. I did not change that one because it might still be in use.

Relates to issue #533

@forki
Copy link
Member

forki commented Sep 4, 2014

Do we want to mark the other one Obsolete?

@Bomret
Copy link
Author

Bomret commented Sep 4, 2014

The new signer is capable of the same tasks as the old one and some new
ones (timestamping). So I'd say yes.
Am 04.09.2014 09:35 schrieb "Steffen Forkmann" [email protected]:

Do we want to mark the other one Obsolete?


Reply to this email directly or view it on GitHub
#535 (comment).

@forki
Copy link
Member

forki commented Sep 4, 2014

How about making the new one backwards compatible?
On Sep 4, 2014 12:48 PM, "Stefan Reichel" [email protected] wrote:

The new signer is capable of the same tasks as the old one and some new
ones (timestamping). So I'd say yes.
Am 04.09.2014 09:35 schrieb "Steffen Forkmann" [email protected]:

Do we want to mark the other one Obsolete?


Reply to this email directly or view it on GitHub
#535 (comment).


Reply to this email directly or view it on GitHub
#535 (comment).

@Bomret
Copy link
Author

Bomret commented Sep 4, 2014

Hmmm, I'd have to port over the original method's signature. I could do
that tomorrow evening.
Am 04.09.2014 12:50 schrieb "Steffen Forkmann" [email protected]:

How about making the new one backwards compatible?
On Sep 4, 2014 12:48 PM, "Stefan Reichel" [email protected]
wrote:

The new signer is capable of the same tasks as the old one and some new
ones (timestamping). So I'd say yes.
Am 04.09.2014 09:35 schrieb "Steffen Forkmann" [email protected]:

Do we want to mark the other one Obsolete?


Reply to this email directly or view it on GitHub
#535 (comment).


Reply to this email directly or view it on GitHub
#535 (comment).


Reply to this email directly or view it on GitHub
#535 (comment).

@forki
Copy link
Member

forki commented Sep 4, 2014

Nice. That would make things so much more friendly
On Sep 4, 2014 2:31 PM, "Stefan Reichel" [email protected] wrote:

Hmmm, I'd have to port over the original method's signature. I could do
that tomorrow evening.
Am 04.09.2014 12:50 schrieb "Steffen Forkmann" [email protected]:

How about making the new one backwards compatible?
On Sep 4, 2014 12:48 PM, "Stefan Reichel" [email protected]
wrote:

The new signer is capable of the same tasks as the old one and some
new
ones (timestamping). So I'd say yes.
Am 04.09.2014 09:35 schrieb "Steffen Forkmann" <
[email protected]>:

Do we want to mark the other one Obsolete?


Reply to this email directly or view it on GitHub
#535 (comment).


Reply to this email directly or view it on GitHub
#535 (comment).


Reply to this email directly or view it on GitHub
#535 (comment).


Reply to this email directly or view it on GitHub
#535 (comment).

Added the old method provided by the old SignHelper and marked it as obsolete. Renamed the properties "File" and "Password" of the SignCert type to "CertFile" and "PasswordFile" to make it more clear what they mean. Also added documentation to those properties.
@Bomret
Copy link
Author

Bomret commented Sep 5, 2014

I included the old SignHelper method in the new SignToolHelper module and marked it as obsolete. The old SignHelper type is still there and unchanged.

forki added a commit that referenced this pull request Sep 19, 2014
@forki forki merged commit 1e77d02 into fsprojects:master Sep 19, 2014
@forki
Copy link
Member

forki commented Sep 19, 2014

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants