Support for OpenCover #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,68 @@ | |||
| [<AutoOpen>] | |||
There was a problem hiding this comment.
please remove the AutoOpen - we try to get rid of it everywhere in FAKE
|
cool. thanks. I made some small comments. |
| let param = setParams OpenCoverDefaults | ||
|
|
||
| let processArgs = | ||
| let args = ref (new StringBuilder()) |
There was a problem hiding this comment.
Please add traceStartTask and traceEndTask - see https://github.com/fsharp/FAKE/blob/develop/src/app/FakeLib/DotCover.fs#L159
|
thanks. |
|
My pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My 1st official attempt at F#, so let me know if there are any problems.
As mentioned in #356, will look at support for ReportGenerator asap.