-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BulkReplaceAssemblyInfoVersions #394
Conversation
I'd extract the lambda which overwrites the default parameters instead of passing (asmVersion:string) (asmInfoVersion:string) directly. What do you think about something like the following?
it would allow me to pass all the defined parameters. |
I like your solution very much, it makes it possible to configure more parameters without having a huge load of parameters. |
Also I'm wondering if it would be helpful if the thing would also process F# AssemblyInfo files. |
And a sample in the docs would be nice. See https://github.com/fsharp/FAKE/blob/develop/src/app/FakeLib/TypeScript.fs#L96 |
You are right, it should certainly also support F# AssemblyInfo files.
I will definetly have a look at this sample document and try to add a minimal working example. |
should work, but I'm not sure if ReplaceAssemblyInfoVersions works for both types. |
maybe we should reuse ZeroToNine library? |
what would that give us? |
It supports C#, F# and even VB type of Actually I got the subject of the issue wrong and thought it's about implementing the |
But we have this functionality - or do I miss something? |
Is anyone of you actually developing FAKE on Linux? |
I know some people did. And we have a CI build which builds on mono. It's on macos though |
It was just a thought. Never mind. |
@mexx no honestly. I want to understand your proposal. |
Added BulkReplaceAssemblyInfoVersions
Allows to update multiple AssemblyInfo files at once