Visual Studio aware msbuild selection #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code reviews welcome :D |
hmemcpy
force-pushed
the
VS-aware-msbuild
branch
from
6a3acde to
1d1b4e1
Compare
forki
reviewed
Jan 17, 2017
| @"c:\Windows\Microsoft.NET\Framework\v3.5\" | ||
| ] | ||
|
|
||
| let toDict items = |
There was a problem hiding this comment.
can we call it toMap - since there is a dict function in FSharp.Core that actually put things in a dict
…lStudioVersion' environment variable, with fallback to the previous lookup.
hmemcpy
force-pushed
the
VS-aware-msbuild
branch
from
1d1b4e1 to
acaa2cf
Compare
|
cool. does it fall back to the old behaviour? |
|
Yup, if it fails to find |
|
cool! |
|
Yay! Thank you! |
|
should be released. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
VisualStudioVersionenvironment variable (which is specified by VS/developer command prompt), so that a compatible msbuild version will be used.This fixes #1452