Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display original server response when failing to parse JSON in Fake.Deploy #1432

Merged
merged 2 commits into from
Dec 17, 2016
Merged

Display original server response when failing to parse JSON in Fake.Deploy #1432

merged 2 commits into from
Dec 17, 2016

Conversation

AlexSugak
Copy link

This does two things:

  • replaces WebRequest with HttpClient for issuing requests to server
  • adds original server response to the error message in case we cannot parse response to JSON (e.g. it was custom server error)

Context:
Spent a lot of time troubleshooting the deployment error that started to occur as my package grew bigger:

Unhandled Exception: System.Net.ProtocolViolationException: You must write ContentLength bytes to the request stream before calling [Begin]GetResponse.
   at System.Net.HttpWebRequest.GetResponse()

In my case Fake.Deploy was behind nginx proxy.
So the root cause for me was package size being bigger than nginx's client_max_body_size.
Had to replace WebRequest with HttpClient to actually receive nginx's 413 response.
But even after that, the only thing that I saw in output was Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0. error.
So had to change response parsing logic to include original response into error message.
Now, if server returns something that is not a JSON we expect, the output will look like this:

Deployment of ./publish/<my package>.nupkg to http://<address>/deploy/fake failed
Fake.Json+ParsingException: Faied to parse input: <html>
<head><title>413 Request Entity Too Large</title></head>
<body bgcolor="white">
<center><h1>413 Request Entity Too Large</h1></center>
<hr><center>nginx/1.10.2</center>
</body>
</html>
 ---> Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.
   at Newtonsoft.Json.JsonTextReader.ParseValue()
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.ReadForType(JsonReader reader, JsonContract contract, Boolean hasConverter)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
   at Fake.Json.tryDeserialize[a](String s) in C:\<path>\FAKE\src\app\Fake.Deploy.Lib\Json.fs:line 24
   --- End of inner exception stack trace ---

@forki
Copy link
Member

forki commented Dec 17, 2016

cool. thanks.

@forki forki merged commit e38353e into fsprojects:master Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexSugak @forki