tell the clr to use the cached assemblies even when it tries to reload them with a different context. #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d them with a different context.
| match knownAssemblies.TryGetValue(ev.Name) with | ||
| | true, a -> | ||
| if printDetails then tracefn "Redirect assembly load to known assembly: %s" ev.Name | ||
| a |
There was a problem hiding this comment.
This should be pretty safe.
matthid
force-pushed
the
razorEngine_caching
branch
from
da6a354 to
8cca852
Compare
|
Ah OK the build failure is unrelated and already in master: https://github.com/fsharp/FAKE/branches |
matthid
force-pushed
the
razorEngine_caching
branch
from
d1fd64a to
dd9182e
Compare
|
I tried, but this looks like combination of a mono and an fsharp bug. It seems like either mono crashes or AppVeyor is unable to compile the source code (related change 1584779...83bb9a6#diff-f5364baf6fdad3389e2e231ccf698733R7) |
|
ready to merge? |
|
Yeah, I think now with comparing the publickeytokens the change is not as problematic as before. |
forki
added a commit
that referenced
this pull request
Jan 13, 2016
tell the clr to use the cached assemblies even when it tries to reload them with a different context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that in some situations the runtime loads some of the cached assemblies twice in different "load contexts". This leads to
missingmethodexceptionsortypecastexceptionsor similar exceptions.Currently I have the
-ncoption (to disable cache) in place as a workaround.Note: Please read my follow-up in-line comments as well as one of the changes might be breaking some FAKE scripts.