Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket helper overriding version for project packages #666

Closed
mavnn opened this issue Feb 25, 2015 · 9 comments
Closed

Paket helper overriding version for project packages #666

mavnn opened this issue Feb 25, 2015 · 9 comments

Comments

@mavnn
Copy link
Contributor

mavnn commented Feb 25, 2015

The point of project templates is that information like versions can be lifted from the project. The current paket helper always overrides the version parameter, breaking this completely.

This is a particular problem on solutions with many projects with many different versions.

@mavnn
Copy link
Contributor Author

mavnn commented Feb 25, 2015

I'd suggest making the version field an option and not supply the parameter to paket if it's None, but I'm up for other suggestions.

@forki
Copy link
Member

forki commented Feb 25, 2015

Sounds reasonable. Probably the same with releasenotes

@mavnn
Copy link
Contributor Author

mavnn commented Feb 25, 2015

Want me to add that, or are you in there already?

@forki
Copy link
Member

forki commented Feb 25, 2015

I can do it. Just wondering if we should use null instead. Would be backwards compatible and aligns with the already existing helpers

@mavnn
Copy link
Contributor Author

mavnn commented Feb 25, 2015

Eeeeew. I'll leave it to you :)

@forki forki closed this as completed in b28e4a9 Feb 25, 2015
@forki
Copy link
Member

forki commented Feb 25, 2015

actually it's not that bad here.
You just don't specify a version in build.fsx. You'll never see that null

@mavnn
Copy link
Contributor Author

mavnn commented Feb 25, 2015

Ha. Thanks!
On 25 Feb 2015 13:13, "Steffen Forkmann" [email protected] wrote:

actually it's not that bad here.
You just don sepcify a version in build.fsx. You'll never see that null


Reply to this email directly or view it on GitHub
#666 (comment).

@forki
Copy link
Member

forki commented Feb 25, 2015

maybe it's a sign that this issue is #666

@forki
Copy link
Member

forki commented Feb 25, 2015

released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants