Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] clean up io tests and plan a new set #71

Closed
14 tasks done
Freymaurer opened this issue Oct 13, 2023 · 0 comments · Fixed by #76
Closed
14 tasks done

[Feature Request] clean up io tests and plan a new set #71

Freymaurer opened this issue Oct 13, 2023 · 0 comments · Fixed by #76
Assignees

Comments

@Freymaurer
Copy link
Collaborator

Freymaurer commented Oct 13, 2023

Is your feature request related to a problem? Please describe.

Currently IO tests were created ad-hoc and not really planned. These should get cleaned up and planned out in a senseful way.

Describe the solution you'd like

We must cover:

  • Reading/Writing to/from different io libraries
  • Tables

So for FsSpreadsheet.ExcelIO we must test:

  • READ fom exceljs
  • READ from excel (the app)
  • READ from ClosedXML
  • READ from libre
  • READ from FsSpreadsheet
  • ROUNDABOUT FsSpreadsheet.ExcelIO
  • WRITE

ForFsSpreadsheet.Exceljs we must test:

  • READ fom FsSpreadsheet.ExcelIO
  • READ from excel (the app)
  • READ from ClosedXML #77
  • READ from libre
  • READ from FsSpreadsheet
  • ROUNDABOUT FsSpreadsheet.Exceljs
  • WRITE

More

  • All files must contain a table with different cell value types. We propose the following:
Numbers Strings DateTime Boolean ARCtrl Column ARCtrl Column
1 Hello any true (A) This is part 1 of 2 (A) This is part 2 of 2
2 World any false Tests if column names with whitespace at end can be unique
3 Bye any true
4 Outer Space any false
  • Duplicate this Table to TWO worksheets to also include multiple worksheets.

  • Due to the nature of these tests, we can recycle most of the test files. We only need one file of any kind for read-in.

  • All files written by tests should be prefixed with "WRITE_" so they can be deleted at any point, while all other files MUST never be opened AND saved to avoid corrupting their origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant