Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically add FCS debug package for next minor. #768

Merged
merged 6 commits into from
May 2, 2017

Conversation

matthid
Copy link
Contributor

@matthid matthid commented Apr 29, 2017

Suggestion for #762 (comment)

@matthid
Copy link
Contributor Author

matthid commented Apr 29, 2017

image

AppVeyor doesn't like me anymore apparently :/

@matthid
Copy link
Contributor Author

matthid commented Apr 29, 2017

This is ready now. Some notes:

  • I don't know why all the targets are so fixed around the bin directory. Ideally we can change the variable in build.fsx and the build still works (currently tests and packaging seem to depend on it)
  • We can choose to release the debug version on NuGet (via setting the DEBUG_PACKAGE_PUBLISH environment variable to true)
  • We can disable the build of the debug package by setting DEBUG_PACKAGE to false
  • The package should be available in the project feed. Someone should probably publish the feed url somewhere (It can be found in the project settings -> NuGet) if we decide to not publish the debug package on NuGet itself.

@dsyme dsyme merged commit 0c64cb8 into fsharp:master May 2, 2017
@dsyme
Copy link
Contributor

dsyme commented May 2, 2017

Great work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants