Updated version of https://github.com/fsharp/FSharp.Compiler.Service/pull/593 #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tthid/FSharp.Compiler.Service into matthid-fix_coreclr_msbuild_reference
| #if NETSTANDARD1_5 | ||
| do tcConfigB.useMonoResolution <- true | ||
| do tcConfigB.primaryAssembly <- PrimaryAssembly.DotNetCore | ||
| #endif |
There was a problem hiding this comment.
Just to note: This will actually disable the msbuild resolution code path. Therefore the changes below are not actually needed (at least for my case) and I never tested them. I just wanted to bring some attention there as there seems to be a problem which should be fixed...
|
Very old PR, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #593