Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCS chokes on C# events #423

Closed
Vidarls opened this issue Sep 25, 2015 · 1 comment
Closed

FCS chokes on C# events #423

Vidarls opened this issue Sep 25, 2015 · 1 comment

Comments

@Vidarls
Copy link

Vidarls commented Sep 25, 2015

This is basically me wining cause I can't get Fsharp formatting to do my API docs if I use normal C# events.

This FSF issue has quite a bit of details: fsprojects/FSharp.Formatting#271 and it loks from the discussion there that the underlying cause is FCS not handling the event types of C#.

Now it might be that it is outside the scope of FCS to handle this, but I'm trying my luck none the less.
@dsyme dsyme mentioned this issue Sep 30, 2015
Merged
@dsyme
Copy link
Contributor

dsyme commented Oct 1, 2015

Fixed in FCS 1.4.0.6

@dsyme dsyme closed this as completed Oct 1, 2015
rojepp pushed a commit to rojepp/FSharp.Compiler.Service that referenced this issue Oct 8, 2015
@latkin
Remove unnecessary access modifier conversions for abstract class ctors
a64ecb2 
fixes fsharp#420
closes fsharp#423

commit 90868139ed5a07291142a27ef8ff4e7624e8efb5
Author: latkin <[email protected]>
Date:   Thu May 7 17:21:49 2015 -0700

    Fix up surface area tests

commit 7b544fff68021f8672ec4ed29ad82237babd77f9
Author: latkin <[email protected]>
Date:   Wed May 6 17:12:07 2015 -0700

    Add/adjust tests

commit 5ab7886e3a5f97c3153605e18bf9b5e0fb762023
Author: latkin <[email protected]>
Date:   Wed May 6 14:38:34 2015 -0700

    Remove unnecessary access modifier conversions for abstract class ctors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vidarls @dsyme