サーバーをesbuildに変更 #259
Merged
サーバーをesbuildに変更 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1. - [Release notes](https://github.com/sindresorhus/normalize-url/releases) - [Commits](https://github.com/sindresorhus/normalize-url/commits) --- updated-dependencies: - dependency-name: normalize-url dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.35 to 7.0.36. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.35...7.0.36) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ws](https://github.com/websockets/ws) from 7.4.3 to 7.5.3. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.4.3...7.5.3) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Solufa <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) --- updated-dependencies: - dependency-name: hosted-git-info dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
|
テストで落ちてるので修正予定 |
|
@solufa @LumaKernel
プラグラインを使えば一応動くのですが、ソース見た感じTypescriptのコンパイラを使っているっぽいのでビルドのスピードが遅くなるのではないかと...（この辺り） これどう対応しましょうか？ |
|
Sorry for late review. ライブラリには .d.ts の生成が必要ですが、アプリケーションには必要ないと思います。必要になったのはどのような経緯でしょうか。 |
|
あ、typeorm ですかなるほど。 |
|
それは仕方ないですね、typeorm は省く、などで良いと思います。 今のところ、type def 生成を tsc 以外でやったという話はないはずなので、type 情報を使う以上、tsc を使うのは仕方ないです。 |
|
一応方針を固めると、prisma のみ変更で typeorm はもとのままで良いかなと思います。 |
|
落ちる時と落ちない時があるな... |
|
|
targetをnode12にするのが良さそうですね。ありがとうございます。
ORMがないパターンもesbuildで対応してみました。お手数ですが、ご確認をお願いします。 |
LumaKernel
approved these changes
Oct 10, 2021
LumaKernel
reviewed
Nov 20, 2021
server/templates/server/package.json
Outdated
| @@ -4,12 +4,12 @@ | |||
| "private": true, | |||
| "scripts": { | |||
| "dev": "<% if (orm === 'prisma') { %>npm run migrate:dev && <% } %>run-p dev:*", | |||
| "dev:server": "webpack --watch --mode=development", | |||
| "dev:server": "<% if (orm === 'typeorm') { %>webpack --watch --mode=development<% } else { %>node ./scripts/build.dev.js & node-dev index.js<% } %>", | |||
There was a problem hiding this comment.
Long living 系は node-dev --respawn と指定しないと、 index.ts をいじって、一瞬、すぐ終わる形になったときに、再起動しなくなる。あったほうがよいかも？
ghost
approved these changes
Jan 16, 2022
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What kind of change does this PR introduce? (check at least one)
Description
Issue Number: 251
サーバー側をWebpackからesbuildに変更しました。