Fix missing runtime apis metadata #820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magecnion
changed the title
impl_runtime_apis! macro to same file as construct_runtime!
|
curious, how did you discover this fix? seems quite unintuitive We had the same problem and seems like we made progress, so thanks a lot! |
|
Reading around and looking at other runtimes I realized that the rest of the parachains have both macros ( @ozgunozerk you can track the issue here #821, as this will be disregarded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
impl_runtime_apis!macro to same file asconstruct_runtime!, then all the apis implemented are included in the metadata generated. You can check by running:subxt metadata --version 15 -f json > local_metadata15 --url http://127.0.0.1:9999