Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pycparser to 2.21 in all requirements files #6686

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

audiodude
Copy link
Contributor

@audiodude audiodude commented Nov 13, 2022

Status

Ready for review

Description of Changes

Fixes #6618

Changes proposed in this pull request:

Upgrade of pycparser library.

Testing

Tested with make test.

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.

Not sure how production instances receive updates from requirements files.

  1. New installs.

Should be fine.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you added or removed a file deployed with the application:

N/A

If you made non-trivial code changes:

N/A

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

If you added or updated a production code dependency:

Production code dependencies are defined in:

  • admin/requirements.in
  • admin/requirements-ansible.in
  • securedrop/requirements/python3/securedrop-app-code-requirements.in

If you changed another requirements.in file that applies only to development
or testing environments, then no diff review is required, and you can skip
(remove) this section.

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

@audiodude audiodude requested a review from a team as a code owner November 13, 2022 20:19
@nathandyer
Copy link
Contributor

Tested locally using make-dev, verified I could create and log into a journalist account. Diff review is approved. This should be in a mergeable state.

@legoktm legoktm merged commit 2370c3e into freedomofpress:develop Nov 13, 2022
@audiodude audiodude deleted the upgrade-pycparser branch November 14, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade pycparser to 2.19+
3 participants