Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command to install packaging dependencies #1572

Closed

Conversation

gonzalo-bulnes
Copy link
Contributor

@gonzalo-bulnes gonzalo-bulnes commented Oct 4, 2022

Description

The API changed today, and the backwards compatibility mechanism makes the (reasonable) guess that the directory will be named after the project, which is not the case in this CI pipeline.

Unblocks #1565

Test Plan

We've got a 🐔 and 🥚 problem here. CI is failing because both mako is outdated and because the securedrop-debian-packaging API has changed.

I want to fix CI before upgrading mako or any other dependency. (I'm waiting on this fix to upgrade the [development dependencies for example][dev], and upgrading mako, and fixing CI for Bookworm.) Please bear with me as I push the limit of merging with a meaningfully failing CI. 🐻


[dev]:

The API changed today, and the backwards compatibility mechanism
makes the (reasonable) guess that the directory will be names
after the project, which is not the case in this CI pipeline.
@gonzalo-bulnes gonzalo-bulnes added 🍓 Bite-sized This pull request should be very quick to review. ⚙️ Tooling Improving maintainability and increasing maintainer joy : ) 🔥 Blocker This PR is somewhat urgent. labels Oct 4, 2022
@gonzalo-bulnes gonzalo-bulnes requested a review from legoktm October 4, 2022 04:33
@gonzalo-bulnes gonzalo-bulnes requested a review from a team as a code owner October 4, 2022 04:33
@gonzalo-bulnes gonzalo-bulnes mentioned this pull request Oct 4, 2022
3 tasks
@legoktm
Copy link
Member

legoktm commented Oct 4, 2022

As discussed, I want to fix the breaking changes instead of needing to fix each repo like this. See freedomofpress/securedrop-builder#384.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Blocker This PR is somewhat urgent. ⚙️ Tooling Improving maintainability and increasing maintainer joy : ) 🍓 Bite-sized This pull request should be very quick to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants