Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

feat: ability to unlink calendar event #2557

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

gikf
Copy link
Member

@gikf gikf commented Apr 4, 2023

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the main branch of Chapter.

Ref #2168


  • Adds ability to unlink calendar event after test.
  • Test is a bit a lie. It doesn't check access to calendar event directly. It lists events from the chapter calendar (via the calendar_id), and checks, if calendar_event_id is among events for the chapter calendar. There are three possible results:
    • No matching event - calendar event either was deleted or (assumed) there's no access to it. Unlinking is possible.
    • Matching event - calendar event exists and there should be access to it, as we have access to chapter calendar. No unlinking.
    • Events can't be listed - this likely means there's no access to chapter. Right now this case is thrown together with other unexpected errors. No unlinking.
  • I thought about just getting event instead. While it might prove complete lack of access, I'm unsure it could prove that chapter has full access to calendar event.

@gikf gikf added UI/UX This issue deals with UI/UX API status: ready for review labels Apr 4, 2023
@gikf gikf requested a review from a team April 4, 2023 19:27
@ghost
Copy link

ghost commented Apr 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ojeytonwilliams ojeytonwilliams merged commit 236f04c into freeCodeCamp:main Jun 8, 2023
@gikf gikf deleted the feat/calendar-event-unlink branch June 14, 2023 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API status: ready for review UI/UX This issue deals with UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants