Round the number before converting it to a BigInt for ModBus #1325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for this awesome project, this is an incredible powerful software!
I ran into a problem while trying to use a
Divisor
with anInt64
ModBus value. Reading the value works fine, but writing was throwing the following error:BigInt
only accepts integers, so in my opinion the correct behavior should be to round the value to the closest integer whentoCast
is true, which is only the case for integer types so this won't affect float types. I tested it with these changes and it fixed the problem for me.There is also some whitespace changes from my editor, let me know if you want me to remove them.