Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alarm counter in header to display only active alarms #1229

Conversation

mauroalexandre
Copy link
Contributor

Currently, the alarm counter in the header sums all alarms regardless of their status, including those with the status AlarmStatusEnum.VOID, resulting in an incorrect number.

This pull request modifies the counter to display only the ACTIVE alarms. This behavior is standard in other tools, but we can improve it in the future to make this behavior configurable.

@unocelli
Copy link
Member

Your modification only counts alarms that are in status ON, for me OFF and ACK status must also be counted, therefore all those in the alarms table, alarms are then removed from the table automatically according to the mode. Maybe the issue you are having is a different one and there are 'ghost' alarms left in the table (not removed for another issue).

@LordNetro
Copy link

LordNetro commented Jun 18, 2024

It happens to me whenever I press the ACK all only, any thoughts? I think there is a problem with that button, it only happens when I click that. See image for example:
image

@MatthewReed303
Copy link
Collaborator

I can confirm I have issues with the alarm count also, if you ACK one alarm at a time it will be correct, if you ACK all it stuffs up the count. This has be a complaint from multiple customers. The alarm count indicator should only display active alarms and that's it

unocelli added a commit that referenced this pull request Jun 19, 2024
@unocelli
Copy link
Member

Thanks for the report, the issue should be fixed

@unocelli
Copy link
Member

unocelli commented Jun 28, 2024

Hi, can you please confirm that the problem has been solved

@mauroalexandre
Copy link
Contributor Author

Hi, can you please confirm that the problem has been solved

Solved, thanks. In sometimes status = '', your codeguard fixed this.

Thanks alot.

@unocelli unocelli closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants