Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By modifying the Chen--Nguyen'11 simulator to not compute the sum in each iteration, but instead keep track of the volume of a block of the basis, this code is shorter (I hope more readable) and ~8x faster. Moreover, add a
log_simulator
method, which works on thelog2(sqrt(squared GS))
norms, which is used in the lattice-estimator (see discussion in malb/lattice-estimator#128 ).The documentation suggests that the code yields the exact same answers.
Also, normalized "EXAMPLE::" as there were some files having a space, and
bkz_simulator.py
had a single colon so the code may not have been checked in CI (an import was missing for average_simulator_prob).