Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix test isolate #9468

Merged
merged 1 commit into from
Dec 3, 2024
Merged

chore: fix test isolate #9468

merged 1 commit into from
Dec 3, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Dec 3, 2024 •
edited by zerosnacks
Loading

@grandizzy grandizzy marked this pull request as ready for review December 3, 2024 11:06
zerosnacks
zerosnacks approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/forge/tests/cli/script.rs
Comment on lines +1926 to +1928
if cfg!(feature = "isolate-by-default") {
return;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I was looking for a way to have the fields of the JSON blob be more lenient yet still checked in Snapbox but couldn't get it to work.

@grandizzy grandizzy merged commit 8ef1302 into master Dec 3, 2024
46 checks passed
@grandizzy grandizzy deleted the grandizzy/fix-test-isolate branch December 3, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grandizzy @zerosnacks