fix(chisel): final statement & fetch err with complex type fixes #9081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
changed the title
grandizzy
changed the title
grandizzy
changed the title
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
DaniPopes
reviewed
Oct 9, 2024
| @@ -528,7 +528,22 @@ impl ChiselDispatcher { | |||
| err.name, | |||
There was a problem hiding this comment.
omg why does this exist. We have ABI to solidity in cast and forge already, and a whole crate to interface with etherscan (foundry-block-explorers), please just use those to fix a trillion other bugs
There was a problem hiding this comment.
this definitely needs a cleanup pass but should happen in a followup
mattsse
approved these changes
Oct 9, 2024
| @@ -528,7 +528,22 @@ impl ChiselDispatcher { | |||
| err.name, | |||
There was a problem hiding this comment.
this definitely needs a cleanup pass but should happen in a followup
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
…ndry-rs#9081) * fix(chisel): consider assembly block return as final statement * Fix 4938 * Start from first assembly block when checking for return statement * Fix 6618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4617 consider first assembly block return as final statement if any
Closes #4938 do not consider yul var declaration statement as final statement
Closes #6618 proper handle of custom error complex type when fetched from etherscan
Solution