Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace criterion with divan #9080

Merged
merged 1 commit into from
Oct 10, 2024
Merged

chore: replace criterion with divan #9080

merged 1 commit into from
Oct 10, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Oct 9, 2024 •
edited
Loading

This lets us reclaim the cast package name

I removed the forge and chisel benches

@DaniPopes DaniPopes enabled auto-merge (squash) October 9, 2024 13:16
@DaniPopes DaniPopes mentioned this pull request Oct 9, 2024
Merged
mattsse
mattsse approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cast bros, we're so back

@DaniPopes DaniPopes merged commit da94707 into master Oct 10, 2024
22 checks passed
@DaniPopes DaniPopes deleted the dani/rm-criterion branch October 10, 2024 20:46
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
@DaniPopes @rplusq
chore: replace criterion with divan (foundry-rs#9080)
6e45151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse