Correct EcPoint const time comparison and better comments and namings
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Taowyoo
commented
Feb 8, 2024
Taowyoo
commented
- Better comments
- Better naming
- Better comments - Better naming
Taowyoo
commented
Feb 8, 2024
| /// The implementation is based on C mbedtls function [`mbedtls_ecp_point_cmp`]. | ||
| /// This new implementation ensures there is no shortcut when any of `x, y ,z` fields of two points is not equal. | ||
| /// | ||
| /// [`mbedtls_ecp_point_cmp`]: https://github.com/fortanix/rust-mbedtls/blob/main/mbedtls-sys/vendor/library/ecp.c#L809-L825 |
There was a problem hiding this comment.
One TBD here:
The mpi_cmp_mpi is also not const time.
Should I use other mpi const time function to implement this?
There was a problem hiding this comment.
Such as this:
/**
* \brief Check if an MPI is less than the other in constant time.
*
* \param X The left-hand MPI. This must point to an initialized MPI
* with the same allocated length as Y.
* \param Y The right-hand MPI. This must point to an initialized MPI
* with the same allocated length as X.
* \param ret The result of the comparison:
* \c 1 if \p X is less than \p Y.
* \c 0 if \p X is greater than or equal to \p Y.
*
* \return 0 on success.
* \return MBEDTLS_ERR_MPI_BAD_INPUT_DATA if the allocated length of
* the two input MPIs is not the same.
*/
int mbedtls_mpi_lt_mpi_ct(const mbedtls_mpi *X, const mbedtls_mpi *Y,
unsigned *ret);
There was a problem hiding this comment.
Yes, was going to suggest this.
There was a problem hiding this comment.
Sure! Reimplemented it with calling mbedtls_mpi_lt_mpi_ct twice on x,y,z.
Taowyoo
force-pushed
the
yx/ecp_refactor
branch
from
3a1684f to
5a3daa1
Compare
mzohreva
reviewed
Feb 10, 2024
zugzwang
reviewed
Feb 12, 2024
zugzwang
approved these changes
Feb 12, 2024
zugzwang
requested changes
Feb 12, 2024
- Better comments - Better naming
- Add `Mpi` const time compare. - Refactor `EcPoint` const time compare.
Taowyoo
force-pushed
the
yx/ecp_refactor
branch
from
5a3daa1 to
dcc0d62
Compare
Taowyoo
force-pushed
the
yx/ecp_refactor
branch
from
dcc0d62 to
eb2cf13
Compare
Taowyoo
changed the title
Taowyoo
changed the title
EcPoint const time comparison and better comments and namings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.