Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ciphertext check for RSADP #339

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Add ciphertext check for RSADP #339

merged 1 commit into from
Dec 20, 2023

Conversation

zugzwang
Copy link
Contributor

In this PR, when decrypting with RSA without padding (e.g. RSA_RAW_DECRYPT), we fail early if the ciphertext is outside {2, ..., n-2}.

Copy link
Collaborator

@Taowyoo Taowyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please run cargo fmt and push again to fix the error from fmt check?

@zugzwang zugzwang force-pushed the francisco/fips-rsadp-bounds branch from ed31f49 to 0a96396 Compare December 20, 2023 09:25
@Taowyoo Taowyoo merged commit 51429f1 into main Dec 20, 2023
10 checks passed
@Taowyoo Taowyoo deleted the francisco/fips-rsadp-bounds branch December 20, 2023 16:54
Taowyoo added a commit that referenced this pull request Jan 26, 2024
Bump mbedtls to 0.12.2 to have a new version to include #339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants