Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macos build #333

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Fix macos build #333

merged 4 commits into from
Nov 2, 2023

Conversation

Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Nov 2, 2023

This PR:

DrTobe and others added 4 commits November 2, 2023 09:39
@DrTobe @Taowyoo
Allow name-mangling for the mbedtls_free, mbedtls_calloc and mbedtls_…
b380ff7 
…ssl_flush_output functions

According to the discussion in
rust-lang/rust-bindgen#1221 (comment),
the \u{1} is a hint to LLVM to avoid name-mangling but this might be required
on some platforms to link against the right name, e.g. on macOS.
@DrTobe @Taowyoo
Add macOS test in CI
20a73f4
@Taowyoo
tests: add missing nextest config
84b7feb
@Taowyoo
build: bump ver
44a18e0
@Taowyoo Taowyoo requested a review from s-arash November 2, 2023 17:44
@Taowyoo Taowyoo mentioned this pull request Nov 2, 2023
Merged
@Taowyoo Taowyoo enabled auto-merge (squash) November 2, 2023 18:07
@Taowyoo Taowyoo requested a review from arai-fortanix November 2, 2023 18:22
@Taowyoo Taowyoo merged commit 053ce3b into main Nov 2, 2023
10 checks passed
@Taowyoo Taowyoo deleted the yx/fix-macos-build branch November 2, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arai-fortanix arai-fortanix arai-fortanix approved these changes

@s-arash s-arash Awaiting requested review from s-arash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Taowyoo @arai-fortanix @DrTobe