Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x509 verify methods that accept expected_common_name #332

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

s-arash
Copy link
Collaborator

@s-arash s-arash commented Oct 30, 2023

This PR just exposes the certificate name validation functionality that is present in mbedtls.

This PR adds two functions to Certificate:

  • verify_with_expected_common_name
  • verify_with_callback_expected_common_name

These functions take an additional expected_common_name parameter and pass it onto mbedtls's verify function.

@s-arash s-arash requested a review from Taowyoo October 30, 2023 20:22
@s-arash s-arash force-pushed the expected-common-name-in-x509-verify branch from 542c01b to 743b606 Compare October 30, 2023 20:28
@s-arash s-arash force-pushed the expected-common-name-in-x509-verify branch from 743b606 to 7a783aa Compare October 30, 2023 20:49
@Taowyoo
Copy link
Collaborator

Taowyoo commented Oct 30, 2023

PLS be free to merge

@Taowyoo Taowyoo merged commit 5c2a215 into fortanix:main Oct 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants