Introduce separate features for pki and tls functionalities of mbedtls #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @s-arash , could you rebase your PR onto latest |
Taowyoo
reviewed
Oct 20, 2023
s-arash
force-pushed
the
granular-features
branch
from
8ed37a4 to
4a33e4c
Compare
What's your preference? I can update the version in this PR. |
Sure let's do it. |
Taowyoo
approved these changes
Oct 20, 2023
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 20, 2023
326: Introduce separate features for pki and tls functionalities of mbedtls r=Taowyoo a=s-arash To statically guarantee that unwanted capabilities of this crate are not used (e.g., a client could only require the crypto functionality of this crate and not its ssl capabilities), this PR introduces two features: `x509` and `ssl`. `x509` enables the pki functionality of the crate and `ssl` enables its tls/ssl capabilities. Co-authored-by: Arash Sahebolamri <[email protected]>
|
Canceled. |
Taowyoo
approved these changes
Oct 20, 2023
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To statically guarantee that unwanted capabilities of this crate are not used (e.g., a client could only require the crypto functionality of this crate and not its ssl capabilities), this PR introduces two features:
x509andssl.x509enables the pki functionality of the crate andsslenables its tls/ssl capabilities.