Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.9] update mbedtls-sys to 2.28.3 #315

Merged
merged 5 commits into from
Sep 11, 2023
Merged

[v0.9] update mbedtls-sys to 2.28.3 #315

merged 5 commits into from
Sep 11, 2023

Conversation

Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Sep 11, 2023 •
edited
Loading

This PR upgrade the mbedlts-sys-auto to 2.28.3 by checkout the code under mbedtls-sys to tag mbedlts-sys-auto_v2.28.3.

This help the maintenance of the v0.9 branch, especially when we need to introduce new changes in mbedtls-sys folder.

@Taowyoo Taowyoo changed the title Yx/v0.9 upgrade mbedtls sys [v0.9] upgrade mbedtls sys Sep 11, 2023
@Taowyoo Taowyoo changed the title [v0.9] upgrade mbedtls sys [v0.9] update mbedtls-sys to 2.28.3 Sep 11, 2023
@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Sep 11, 2023

bors try

bors bot added a commit that referenced this pull request Sep 11, 2023
@bors
Try #315:
1f39e0a
arai-fortanix
arai-fortanix reviewed Sep 11, 2023
View reviewed changes
Copy link

@arai-fortanix arai-fortanix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all of the changes under vendor come from upstream, or are there any manual changes?

mbedtls-sys/vendor/.travis.yml Show resolved Hide resolved
@bors
Copy link
Contributor

bors bot commented Sep 11, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

  • continuous-integration/travis-ci/push

DrTobe and others added 5 commits September 11, 2023 13:07
@DrTobe @Taowyoo
Replace vendor directory with mbedtls-2.28.3
64b4c85
@Taowyoo
Vendor Change:-
cf13aec 
1. Added conditional compilation flags "MBEDTLS_FORCE_AESNI" and "MBEDTLS_FORCE_PADLOCK"
2. This allows us to supress cpuid based feature detection on sgx platforms.
3. "MBEDTLS_FORCE_AESNI" gets set if "force_aesni_support" flag is enabled.
4. Please refer to the previous commit for rust side changes.

(cherry picked from commit d2317b0)
@raoulstrackx @Taowyoo
Adding mpi_force_c_code feature
044be6a 
(cherry picked from commit 38522c2)
@DrTobe @Taowyoo
Bump version to 2.28.3
7276100
@DrTobe @Taowyoo
Update Cargo.lock file
a96442c
@Taowyoo Taowyoo force-pushed the yx/v0.9_upgrade-mbedtls-sys branch from 932bece to a96442c Compare September 11, 2023 20:08
@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Sep 11, 2023

bors try

bors bot added a commit that referenced this pull request Sep 11, 2023
@bors
Try #315:
0a70e87
arai-fortanix
arai-fortanix approved these changes Sep 11, 2023
View reviewed changes
Copy link

@arai-fortanix arai-fortanix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Sep 11, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 11, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors
Copy link
Contributor

bors bot commented Sep 11, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 5e1b00a into v0.9 Sep 11, 2023
@Taowyoo Taowyoo deleted the yx/v0.9_upgrade-mbedtls-sys branch September 11, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arai-fortanix arai-fortanix arai-fortanix approved these changes

@MihirLuthra MihirLuthra Awaiting requested review from MihirLuthra

@raoulstrackx raoulstrackx Awaiting requested review from raoulstrackx

@arushi-pahuja arushi-pahuja Awaiting requested review from arushi-pahuja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Taowyoo @arai-fortanix @DrTobe @raoulstrackx