New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[back-port][v0.9] fix: return error when verify empty cert chain #309

Merged

bors merged 2 commits into v0.9 from yx/back-port_pr308

Aug 30, 2023

Collaborator

Taowyoo commented Aug 21, 2023

back-port #308 to 0.9.X

Taowyoo requested review from jethrogb, mzohreva, Pagten and raoulstrackx

August 21, 2023 23:10

Taowyoo changed the base branch from master to v0.9

August 21, 2023 23:10

This comment was marked as outdated.

Sign in to view

bors bot added a commit that referenced this pull request


          Try #309:

b151a11

This comment was marked as outdated.

Sign in to view

Taowyoo self-assigned this

Taowyoo linked an issue

that may be closed by this pull request

mbedtls::x509::certificate::Certificate::verify() segfaults when passing in an empty certificate chain to verify #307

Closed

3 tasks

Taowyoo force-pushed the yx/back-port_pr308 branch from 56f2a7c to 1e65d22 Compare

August 22, 2023 05:53

Contributor

raoulstrackx commented Aug 22, 2023

CI failed with:

  thread 'main' panicked at '"x509_san_other_name_union_(unnamed_at_vendor/include/mbedtls/x509_crt_h_115_5)" is not a valid Ident', /home/travis/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.24/src/fallback.rs:693:9

If I remember correctly, this is caused by a combination of bindgen/clang-11. Updating the compiler to clang-12 should resolve the issue. Switching to GitHub Actions as part of this PR is a bit weird.

This comment was marked as outdated.

Sign in to view

bors bot added a commit that referenced this pull request


          Try #309:

584c282

Collaborator Author

Taowyoo commented Aug 22, 2023

CI failed with:
  thread 'main' panicked at '"x509_san_other_name_union_(unnamed_at_vendor/include/mbedtls/x509_crt_h_115_5)" is not a valid Ident', /home/travis/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.24/src/fallback.rs:693:9
If I remember correctly, this is caused by a combination of bindgen/clang-11. Updating the compiler to clang-12 should resolve the issue. Switching to GitHub Actions as part of this PR is a bit weird.

Actually it's odd because there is actually no change on bindgen crate and clang11. What is only changed is rust toolchain.

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

bors bot added a commit that referenced this pull request


          Try #309:

7f39787

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

bors bot added a commit that referenced this pull request


          Try #309:

a64f1fd

This comment was marked as outdated.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

bors bot added a commit that referenced this pull request


          Try #309:

e47710e

This comment was marked as outdated.

Sign in to view

Taowyoo force-pushed the yx/back-port_pr308 branch from 330cf29 to f3cf6dc Compare

August 22, 2023 19:22

This comment was marked as outdated.

Sign in to view

bors bot added a commit that referenced this pull request


          Try #309:

fe3421f

This comment was marked as outdated.

Sign in to view

Taowyoo force-pushed the yx/back-port_pr308 branch from f3cf6dc to 035aed5 Compare

August 22, 2023 21:28

Taowyoo added 2 commits

August 29, 2023 21:05


          fix: verify empty candidate cert chain

fc8226e

- Verify empty candidate cert chain
- Add other necessary empty List check


          ci: fix Travis CI

0eeea4e

Taowyoo force-pushed the yx/back-port_pr308 branch from 541074e to 0eeea4e Compare

August 30, 2023 04:07

Collaborator Author

Taowyoo commented Aug 30, 2023

bors try

bors bot added a commit that referenced this pull request


          Try #309:

d53bc24

Contributor

bors bot commented Aug 30, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

continuous-integration/travis-ci/push

xinyufort commented Aug 30, 2023

bors r+

xinyufort approved these changes

View reviewed changes

xinyufort left a comment

As per Slack discussion in thread https://fortanix.slack.com/archives/CK39ZV0KA/p1693421657593469

bors bot merged commit e0d2836 into v0.9

Contributor

bors bot commented Aug 30, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

continuous-integration/travis-ci/push

Taowyoo deleted the yx/back-port_pr308 branch

September 5, 2023 23:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

xinyufort xinyufort approved these changes

jethrogb Awaiting requested review from jethrogb

mzohreva Awaiting requested review from mzohreva

Pagten Awaiting requested review from Pagten

raoulstrackx Awaiting requested review from raoulstrackx

Labels

None yet