Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant Result type for byte_length() and bit_length() #193

Closed
wants to merge 1 commit into from
Closed

remove redundant Result type for byte_length() and bit_length() #193

wants to merge 1 commit into from

Conversation

MihirLuthra
Copy link
Member

No description provided.

@MihirLuthra MihirLuthra requested a review from jethrogb March 25, 2022 14:01
@Taowyoo Taowyoo force-pushed the mihir/rm-redundant-result-type branch from be20a18 to f4c91aa Compare March 15, 2023 04:10
@Taowyoo Taowyoo self-requested a review July 18, 2023 20:38
@Taowyoo Taowyoo changed the base branch from master to main October 19, 2023 21:02
@Taowyoo Taowyoo changed the base branch from main to master October 19, 2023 21:02
@Taowyoo
Copy link
Collaborator

Taowyoo commented Oct 19, 2023

Because of change of default branch to main.
See more:

This PR need to rebase to main

@Taowyoo Taowyoo force-pushed the mihir/rm-redundant-result-type branch from 842c484 to f94fafe Compare October 27, 2023 01:30
@Taowyoo Taowyoo changed the base branch from master to main October 27, 2023 01:30
@Taowyoo
Copy link
Collaborator

Taowyoo commented Oct 27, 2023

bors try

bors bot added a commit that referenced this pull request Oct 27, 2023
@bors
Try #193:
0729321
@bors
Copy link
Contributor

bors bot commented Oct 27, 2023

try

Build failed:

@Taowyoo Taowyoo closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taowyoo Taowyoo Taowyoo approved these changes

@jethrogb jethrogb Awaiting requested review from jethrogb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MihirLuthra @Taowyoo