Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chain_id label to prometheus to improve alert monitoring #68

Conversation

MonikaCat
Copy link
Contributor

Description

Fixes BDU-280

  • Added chain_id label to prometheus’ juno_last_indexed_height metric

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Re-reviewed Files changed in the Github PR explorer.

@MonikaCat MonikaCat changed the title feat: added chain_id label to improve alert monitoring feat: add chain_id label to prometheus to improve alert monitoring May 11, 2022
@MonikaCat MonikaCat requested a review from huichiaotsou May 11, 2022 15:04
@MonikaCat MonikaCat added the automerge Automatically merge PR once all prerequisites pass label May 11, 2022
@MonikaCat MonikaCat requested a review from RiccardoM May 24, 2022 18:47
@huichiaotsou
Copy link
Contributor

Hi @RiccardoM, @maiquanghiep might need this log as soon as possible for their alert, can we release a minor version and upgrade bdjuno once this PR is merged?

@mergify mergify bot merged commit 5c9b026 into cosmos/v0.44.x May 26, 2022
@mergify mergify bot deleted the BDU-280-improve-the-alert-monitoring-whenever-the-latest-block-height-in-bigdipper-is-behind branch May 26, 2022 10:20
RiccardoM pushed a commit that referenced this pull request May 26, 2022
…68)

## Description

Fixes BDU-280
- Added `chain_id` label to prometheus’ `juno_last_indexed_height` metric

## Checklist
- [x] Targeted PR against correct branch.
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Wrote unit tests.  
- [x] Re-reviewed `Files changed` in the Github PR explorer.
@RiccardoM
Copy link
Contributor

@huichiaotsou Tagged v.3.2.1 and v3.2.1-stargate with this change alone inside

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants