Fix logging getting stuck when maxlog is specified and don't print maxlog, fixes #1902
#1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version would hang of there were multiple logs and one of them had maxlog set.
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/Joel-Dahne/Pluto.jl", rev="maxlog-stuck")
julia> using Pluto |
|
I added documentation for |
|
Thanks so much for adding tests, really helpful!! |
It now uses poll only in the first step when waiting for all log message to arrive.
Armed with this knowledge I slightly rewrote the tests! |
|
I'm not sure if the failed tests are related? |
|
Perfect, thanks so much! |
This was
linked to
issues
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #1902. It contains two commits. The first one fixes it so that it doesn't get stuck if multiple logs are encountered when
maxlogis used on one of them. The second one removes themaxlogfrom the log-message, in line with how Julia handles it. It also adds tests for both of these behaviors.This is the first time I'm contributing to Pluto so there are some things it would be good if they could be check.
maxlogelement from the log to not have it be printed in the log-message. I'm not sure if this is the right way to do it. I don't know if updating the log is okay, maybe it is used in other places as well? Maybe it is better to excludemaxlogfrom the message in the frontend instead of backend?pollso I might have misused it.