Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension points and Java auto-detect in Flatpak #131

Closed
wants to merge 7 commits into from
Closed

Fix extension points and Java auto-detect in Flatpak #131

wants to merge 7 commits into from

Conversation

zocker-160
Copy link

@zocker-160 zocker-160 commented Dec 30, 2023

Following changes have been made:

  • replaced deprecated / EOL com.valvesoftware.Steam.Utility.gamescope extension
  • added extension point for MangoHud
  • moved ENV variables from starter script into manifest, this way PATH is set correctly also when I use a custom command inside the Flatpak
  • fixed Java 8 appearing twice in the version selector auto-detect function thingy
  • switched x11 socket to fallback-x11, since wayland is the primary socket to use when available

Known issue:

I have not checked the source code yet, but for some reason, the MangoHud check is greyed out despite mangohud being in PATH and confirmed working by adding mangohud --dlsym to Wrapper command.

Screenshot_20231230_161444

Maybe someone knows how PollyMC is checking if mangohud is available or not?
It is available in PATH:

$ flatpak run --command=bash org.fn2006.PollyMC 
[📦 org.fn2006.PollyMC ~]$ which mangohud
/app/utils/mangohud/bin/mangohud

UPDATE:
Issue is fixed with move to 23.08. Users have to have MangoHud flatpak installed

flatpak install org.freedesktop.Platform.VulkanLayer.MangoHud//23.08

and then it will show up correctly in the settings:
Screenshot_20240412_151956

PATH should be set at all times and not only when run though the start script

Signed-off-by: zocker-160 <[email protected]>
Java 21 is required for MC >= 1.20.5
zocker-160 added a commit to zocker-160/FjordLauncher that referenced this pull request May 17, 2024
zocker-160 added a commit to zocker-160/FjordLauncher that referenced this pull request May 17, 2024
@zocker-160
Copy link
Author

closing in favor of: unmojang/FjordLauncher#5

@zocker-160 zocker-160 closed this May 17, 2024
@zocker-160 zocker-160 deleted the fix-flatpak branch May 17, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant